Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect noteable_type type for MergeRequest #3491

Merged
merged 2 commits into from
Dec 25, 2023
Merged

fix: incorrect noteable_type type for MergeRequest #3491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4714db6
fix: incorrect `noteable_type` type for `MergeRequest`
JounQin Dec 19, 2023
3da4096
Code review
jdalrymple Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/resources/MergeRequestNotes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import type {
} from '../infrastructure';

export interface MergeRequestNoteSchema extends NoteSchema {
noteable_type: 'Merge request';
noteable_type: 'MergeRequest';
}

export interface MergeRequestNotes<C extends boolean = false> extends ResourceNotes<C> {
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/templates/ResourceDiscussions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export interface DiscussionNoteSchema extends Record<string, unknown> {
updated_at: string;
system: boolean;
noteable_id: number;
noteable_type: string;
noteable_type: 'Issue' | 'Snippet' | 'Epic' | 'Commit' | 'MergeRequest';
noteable_iid: number | null;
resolvable: boolean;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/templates/ResourceNotes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export interface NoteSchema extends Record<string, unknown> {
updated_at: string;
system: boolean;
noteable_id: number;
noteable_type: 'Issue' | 'Snippet' | 'Epic' | 'Commit' | 'Merge request';
noteable_type: 'Issue' | 'Snippet' | 'Epic' | 'Commit' | 'MergeRequest';
jdalrymple marked this conversation as resolved.
Show resolved Hide resolved
noteable_iid: number;
project_id: number;
resolvable: boolean;
Expand Down