Goal Resource rendering

[tarekadel89]

added rendering for Goal Resource.. Goal.svelte was newly added and IPSContent.svelte was updated

[jddamore]

@tarekadel89 Overall this looks good. 1 comment:

1. I like the date function you use, although I think we've been simpler overall in the viewer. For consistency with other templates, we could change the function formatDate(dateStr: string): string {
   if (dateStr) {
   return dateStr.split("T")[0];
   }
   else return '??'
   // const options: Intl.DateTimeFormatOptions = { day: '2-digit', month: 'short', year: 'numeric' };
   // const date = new Date(dateStr);
   // return date.toLocaleDateString('en-GB', options);
   }
   This looks more consistent with what we do here https://github.com/jddamore/IPSviewer/blob/main/src/lib/components/resource-templates/Condition.svelte#L66 and in other templates

Alternatively, we could stick this function across other templates generally. I do like the DD-mmm-YYYY as it's more readable than the YYYY-mm-dd format. Asking @daniellrgn if he has a preference.

Thanks. Let me know on above and I'll work to get this pulled in and updated on ipsviewer.com next week.

[tarekadel89]

I can align the dates of the Goal resource with the other resources for now. Then if we log another issue, I can go and update all the dates in the viewer and make sure they are in dd-mmm-yyyy format in another pull request. How does that sound?

[tarekadel89]

The date has now been fixed

[jddamore]

Will work to get this integrated and online tomorrow (by end of business 2/11 US ET)

[jddamore]

#31

[jddamore]

@tarekadel89 I merged and updated online. Try out and let me know if anything not working. Any more work you want to do is welcome. I don't get much time to work on this, but it could be a lot better.

[tarekadel89]

Thank you so much.. I just tested and all working as I would expect it

…

On Thu, Feb 13, 2025, 3:39 AM jddamore ***@***.***> wrote: @tarekadel89 <https://github.com/tarekadel89> I merged and updated online. Try out and let me know if anything not working. Any more work you want to do is welcome. I don't get much time to work on this, but it could be a lot better. — Reply to this email directly, view it on GitHub <#30 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4BRTRIJ5FWXN4PWDAPWNUL2PN2K5AVCNFSM6AAAAABWVBRXA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJUGI3DQMZTGI> . You are receiving this because you were mentioned.Message ID: ***@***.***> [image: jddamore]*jddamore* left a comment (jddamore/IPSviewer#30) <#30 (comment)> @tarekadel89 <https://github.com/tarekadel89> I merged and updated online. Try out and let me know if anything not working. Any more work you want to do is welcome. I don't get much time to work on this, but it could be a lot better. — Reply to this email directly, view it on GitHub <#30 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4BRTRIJ5FWXN4PWDAPWNUL2PN2K5AVCNFSM6AAAAABWVBRXA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJUGI3DQMZTGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>