Feature/issue 213 #219
Open
Feature/issue 213 #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use property on CouldNotRetrieveTranscript class to account for dynamic reason in playability json given;
…tempt to extract playability json for better error handling with dynamic reasons; add tests for LoginRequired, VideoUnplayable errors; fix TranscriptDisabled test static html so it uses proper playabilityStatus JSON object;
ilystsov
suggested changes
Oct 31, 2023
commit ilystsov's edits to remove redudant lines within get_playability_subreason error helper function. Co-authored-by: ilystsov <[email protected]>
| """ | ||
| reason = playability_json.get("status") | ||
| if reason == 'LOGIN_REQUIRED': | ||
| # error for age related playability |
There was a problem hiding this comment.
LOGIN_REQUIRED also happens when you need to "Sign in to confirm you’re not a bot". This simpler pull request addresses this: #337
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
_extract_captions_jsonmethod to do additional html splitting to attempt to extract out theplayabilityStatusJSON object so we may match and raise a more specific error against the "status" field.Updates
CouldNotRetrieveTranscriptclass to acceptplayabilityStatusJSON object so we can generate more informative errors with cause, reason, subreason attached.Adds two playability error helper methods:
get_playability_subreason,get_playability_errorAdds tests to cover the 2 new error classes:
VideoUnplayableandLoginRequired