Merge pull request #1606 from jdi-testing/issue_1587_data-attr-unique…

…-bug

Issue 1587: data attr unique bug

manifest.json

@@ -3,7 +3,7 @@
   "name": "JDN",
   "description": "JDN – helps Test Automation Engineer to create Page Objects in the test automation framework and speed up test development",
   "devtools_page": "index.html",
-  "version": "3.14.34",
+  "version": "3.14.35",
   "icons": {
     "128": "icon128.png"
   },

package.json

@@ -1,6 +1,6 @@
 {
   "name": "jdn-ai-chrome-extension",
-  "version": "3.14.34",
+  "version": "3.14.35",
   "description": "jdn-ai chrome extension",
   "scripts": {
     "start": "webpack --watch --env devenv",
@@ -107,7 +107,6 @@
     "eslint-plugin-react": "^7.33.2",
     "eslint-plugin-react-hooks": "^4.6.0",
     "file-loader": "6.2.0",
-
     "html-webpack-plugin": "5.5.3",
     "husky": "^8.0.2",
     "jest": "^29.7.0",

src/features/locators/utils/createLocatorTypeOptions.tsx

@@ -144,6 +144,7 @@ const splitUniqueAndNonUniqueAttributes = (
 
   Object.entries(attributes).forEach(([key, value]) => {
     const keyType = key as keyof ElementAttributes;
+    const isValueEmpty = value === '' || value === null || value === undefined;
 
     if (keyType === 'dataAttributes' && value) {
       // Check and unpacked data-attributes:
@@ -152,10 +153,13 @@ const splitUniqueAndNonUniqueAttributes = (
       const nonUniqueDataAttributes: { [key: string]: string | null } = {};
 
       Object.entries(dataAttributes).forEach(([dataKey, dataValue]) => {
-        if (!attributesHashMap.has(dataKey) || !attributesHashMap.get(dataKey)?.has(dataValue)) {
-          uniqueDataAttributes[dataKey] = dataValue;
-        } else {
+        const isDataValueEmpty = dataValue === '' || dataValue === null || dataValue === undefined;
+        const isNonUnique =
+          isDataValueEmpty || !attributesHashMap.has(dataKey) || !attributesHashMap.get(dataKey)?.has(dataValue);
+        if (isNonUnique) {
           nonUniqueDataAttributes[dataKey] = dataValue;
+        } else {
+          uniqueDataAttributes[dataKey] = dataValue;
         }
       });
 
@@ -167,12 +171,11 @@ const splitUniqueAndNonUniqueAttributes = (
         mergeObjects(nonUniqueAttributes, nonUniqueDataAttributes);
       }
     } else {
-      const isUnique = !attributesHashMap.has(key) || !attributesHashMap.get(key)?.has(value);
-
-      if (isUnique) {
-        uniqueAttributes[keyType] = value;
-      } else {
+      const isNonUnique = isValueEmpty || !attributesHashMap.has(key) || !attributesHashMap.get(key)?.has(value);
+      if (isNonUnique) {
         nonUniqueAttributes[keyType] = value;
+      } else {
+        uniqueAttributes[keyType] = value;
       }
     }
   });