Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1285: more options for locator editing #1573

Merged
merged 32 commits into from
Nov 29, 2023
Merged

Issue 1285: more options for locator editing #1573

merged 32 commits into from
Nov 29, 2023

Conversation

Iogsotot
Copy link
Contributor

@Iogsotot Iogsotot commented Nov 28, 2023 •
edited
Loading

#1285

  • added multiple options for locator editing
  • updated types:
    • LocatorType enum
    • locatorTypes
    • ElementAttributes
    • ExtendedElementAttributes
    • locatorAttributesInitialState
  • added logic for collecting element's attributes for content scripts and for main app
  • updated locator evaluation logic
  • updated locator validation logic
  • added new logic for work with new element attributes:
    • added getLocatorAnnotationStringByType
    • updated getLocator
    • updated getLocatorPrefix
    • refactored renderColorizedString (JDI string)
  • refactored styles for locator
  • fixed code style, naming, types
  • updated tests
  • updated dependencies for rc-filed-form (AntD)

image
image

1285.mp4

@Iogsotot
docs: update version
351dfe1
@Iogsotot
feat: add getElementAttributes fn for content scripts
46bea50
@Iogsotot
feat: collect attributes for locator element in Content Scripts
f14fa5d
@Iogsotot
refactor: fix naming in checkDuplicates fn
e2436ab
@Iogsotot
fix: update tests
5001f35
@Iogsotot
feat: add more node attributes into LocatorEditDialog Select options
a7d2c7c
@Iogsotot
feat: add styles and tooltip for Locator Type Options
75e483b
@Iogsotot
feat: add a-z sort for Locator Type Options
3d19752
@Iogsotot
feat: update interfaces for LocatorType & ElementAttributes
69a72c3
@Iogsotot
feat: add new logic for work with new element attributes - add getLoc…
392ec12 
…atorAnnotationStringByType, update getLocator, update getLocatorPrefix, refactor renderColorizedString (JDI string)
@Iogsotot
fix: update locator's tests and mock
8b3e811
@Iogsotot
refactor: common styles for locator, update styles for xpath
0f51418
@Iogsotot
refactor: fix class naming for DialogWithForm
5c21329
@Iogsotot
refactor: change console.log to warn
ff4a995
@Iogsotot
fix: Locator types
7327569
@Iogsotot
feat: add evaluate fn for attributes (evaluateStandardLocator) instea…
f03d1ea 
…d of evaluateCssSelector, use enum for NotFound returns
@Iogsotot
feat: update logic for using StandardLocator instead of CssSelector; …
575d7ae 
…add evaluateStandardLocator; fix types, imports, naming
@Iogsotot
feat: update logic to get locator type in PageObj Setting Selector
bdf8fa9
@Iogsotot
feat: update locator validation logic; fix naming
b3e47cd
@Iogsotot
refactor: add async for Connector's methods
9d1920d
@Iogsotot
fix: output locator string and locator type logic
3b4f37f
@Iogsotot
fix: update dependencies for rc-filed-form
8dfade2
@Iogsotot
fix: output for CSS Selector in locator edit dialog
1ed8002
@Iogsotot
fix: styles for locators dropdown
9007f02
@Iogsotot
fix: replace replace evaluateCssSelector with evaluateStandardLocator…
28ebf80 
… for related components
@Iogsotot
fix: tests by type casts
c270e1b
@Iogsotot Iogsotot self-assigned this Nov 28, 2023
@Iogsotot Iogsotot force-pushed the issue_1285_more-options-for-locator-editing branch from 1f3c43a to 2de0c0f Compare November 29, 2023 11:42
@Iogsotot Iogsotot force-pushed the issue_1285_more-options-for-locator-editing branch from 86047e0 to 6559888 Compare November 29, 2023 19:54
@Iogsotot Iogsotot merged commit 36aa452 into master Nov 29, 2023
2 of 3 checks passed
@Iogsotot Iogsotot mentioned this pull request Nov 29, 2023
Closed
@Iogsotot Iogsotot linked an issue Nov 29, 2023 that may be closed by this pull request
[US-7-6] Больше опций для выбора типа локатора при его редактировании #1285
Closed
@Iogsotot Iogsotot deleted the issue_1285_more-options-for-locator-editing branch February 7, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Iogsotot Iogsotot

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Iogsotot