Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for typing.overload #22

Merged
merged 4 commits into from
Nov 29, 2023
Merged

add support for typing.overload #22

merged 4 commits into from
Nov 29, 2023

Conversation

jdkandersson
Copy link
Owner

Supersedes #21 and closes #20

@vpoulailleau
Copy link

@jdkandersson LGTM, and it fixes the issues I had on my project. Thanks!

(BTW, I also miss #15, in case of having the docstring for __init__ at the class level to avoid duplication)

@jdkandersson jdkandersson merged commit 83fdea8 into main Nov 29, 2023
16 checks passed
@jdkandersson jdkandersson deleted the overload branch November 29, 2023 07:50
@jdkandersson
Copy link
Owner Author

@vpoulailleau this has been release to pypi now

@vpoulailleau
Copy link

@jdkandersson Great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid raising DCO010 (missing docstring) for overloads
2 participants