-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix edit_uri starting with http when using ssh #120
Conversation
Quick hack working `edit_uri` for git+ssh repos
Version Number CheckUpdate the version in pyproject.toml if you want this PR to generate a new release (main is 0.7.0 >= 0.7.0). |
Apologies for letting this PR hang around. I'd like to add some testing around this feature before merging but have been kicking the can down the road. |
Just noticed the same behavior and that fix would help us as well :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my one comment LGTM.
Quick hack working
edit_uri
for git+ssh reposFixes #119