Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Git Version Parsing/Checking and Added mypy #148

Merged
merged 2 commits into from
Jun 22, 2024
Merged

Improve Git Version Parsing/Checking and Added mypy #148

merged 2 commits into from
Jun 22, 2024

Conversation

jdoiro3
Copy link
Owner

@jdoiro3 jdoiro3 commented Jun 22, 2024 •
edited
Loading

  • The previous way we were parsing the Git version number to check if the version was less than 2.25.0 and supported sparse-checkout was buggy. This PR should improve it.
  • Added a mypy pre-commit hook.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 22, 2024 •
edited
Loading

Version Number Check

Version has been updated in pyproject.toml.

@jdoiro3 jdoiro3 merged commit 5f8f062 into main Jun 22, 2024
14 checks passed
@jdoiro3 jdoiro3 deleted the git-version-fix branch June 22, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jdoiro3