fix script execution in non-PATH directories #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typically on UNIX systems a non-zero code is a failed exit code. The code here doesn't catch anything except 1 but 127 is possible when it cannot find the scripts as seen in issue jdoiro3#122. Higher numbers are possible when a signal interrupts the execution. Switch to treating all non-zero codes as an error.
Version Number CheckVersion has been updated in pyproject.toml. |
|
@cardoe - thanks for contributing! Could you re-lock and push a commit so we can run tests? I'll take a look at the PR soon. |
The code assumes that where this package is installed will result in the scripts living in bash's PATH. If the user is using a virtualenv and uses a shell other than bash then it won't be in the PATH and it will fail. This uses the functionality that Python 3.9 added in importlib to create a temp file with a resource included in the package to run the script. For older versions of Python the backport package is installed and used. fixes jdoiro3#122
Done! |
|
Thanks. Lemme know what I need to do to get it in a release. |
|
@jdoiro3 https://github.com/jdoiro3/mkdocs-multirepo-plugin/actions/runs/10361895254/job/28683098702 looks like the release failed. I think it should be a quick fix and just re-run CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user used a virtualenv and did not have the virtualenv in their PATH. Or they used another shell like zsh and the install location of this plugin was not in bash's PATH (since it forces execution with bash) then it would just silently fail.