-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a Hydra+wandb+submitit-launcher example #79
Added a Hydra+wandb+submitit-launcher example #79
Conversation
Cool! Thanks @zaccharieramzi I would be happy to review this PR once ready. Don't hesitate to ping me. |
Hi @mdiazmel ! Thanks for proposing to review. I think this can be reviewed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks @zaccharieramzi
I tested it in JZ and it works like a charm! From my side, I used the TF version installed from conda-forge and not the version packaged in the modulefile
(as well the other dependencies). I added a couple of comments to clarify things in the README file.
It should be nice to include a direct link in the documentation web page (the vertical menu at the left). I can do that once the PR will be merged.
Hey @mdiazmel thanks for your review! I can merge when you think it's ready. |
LGTM. I'll merge it! |
This solves #78
For now this wasnt tested, this is why I set it as a draft PR.