Fix tests for current package versions. #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are currently two sets of dependency versions for sandman: one set of pinned versions in `requirements.txt` and another set of unpinned versions in `setup.py`. This means that installing via `pip` installs the latest versions of the dependencies, but installing from `requirements.txt` installs older, pinned versions. Several tests fail with the latest versions of Flask-Admin and Flask-WTForms. This patch fixes the breaking tests and installs tests on Travis using `setup.py` for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently two sets of dependency versions for sandman: one set
of pinned versions in
requirements.txtand another set of unpinnedversions in
setup.py. This means that installing viapipinstallsthe latest versions of the dependencies, but installing from
requirements.txtinstalls older, pinned versions. Several tests failwith the latest versions of Flask-Admin and Flask-WTForms.
This patch fixes the breaking tests and installs tests on Travis using
setup.pyfor consistency.