Super timer II support. Fixes #206 #365
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebazar
changed the title
Also fixed an issue with the Java implementation (Found an off by one)
Cleaned up some TODO comments about the timeout since it was fixed already.
|
I've tested the new derby-timer.jar and can confirm that the Super Timer II was properly auto-detected and is registering the times. We just had our Pinewood Derby last weekend and the software our Scout Pack was using (RaceManager) looked challenging. Looking forward to using DerbyNet next year! |
|
Glad to hear your testing went well! I definitely found Race Manager challenging as well... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of the SuperTimer II interface to work with DerbyNet. We ran at least 1 race (26 heats) with it and I fixed the couple issues that cropped up during the race.
I had to add a couple of odd quirks to handle SuperTimer since it only reports times it sees (DNFs are un-reported), and it also reports them on multiple lines. For this I added a partial lane result handling that joins two events. for the DNFs, I added a 'NO_MORE_RESULTS' event that will go through and post all un-marked lanes as a DNF time.
I also added support for a timer to control the post race/heat start timeout since this timer can control the timeout. I could not figure out how to integrate sending the command back to the timer to get it to update the track timeout with the webUI, but most of the logic is there in the HeatPreparation.
Fixes #206