Use native browser APIs and Luxon instead of Moment #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelhan
changed the title
jelhan
changed the title
This was referenced Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes usage of Moment.js and replaces it with native APIs, especially
Intl.DateTimeFormat, and Luxon if relying on native APIs only is not feasible.Croodle recently had a critical bug caused by outdated time zone information used by Moment (#573). Using
Intl.DateTimeFormatwill prevent such bugs in the future as time zone information are updated with the browser. As a side effect Croodle's bundle size is reduced by ~12KB after gzip if not needing to include time zone information.The presentation of dates may slightly change depending on browser and locale. If any change affects the user experience negatively, we can address that in follow-up merge requests.