-
-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video Player Manager Refactor #1203
base: main
Are you sure you want to change the base?
Conversation
Out of curiosity, will part of this refactor include the TODO to move the playback reporting logic? I only ask because Native Player playback reporting seems to be hit or miss. Particularly when the app is closed instead of closing the player more gracefully in-app. I was going to look at it but I can hold off if that's an area you are going to be interacting with. |
Yes, my intention is to fix the playback reporting and some other discrepancies between the players with this as well. |
I'm probably behind the curve here but I was looking at this today: https://developer.apple.com/documentation/avkit/customizing-the-tvos-playback-experience Do you think we have any appetite for this for the Not implying this should be part of this PR! Just thought I would ask before I started looking at this more seriously. |
At least here, I only care about implementing the same capabilities on iOS and tvOS which mostly means only providing the additional metadata. However since tvOS does allow that additional customization with buttons I'm not necessarily against their implementation but I will not personally actively seek to implement them. If someday Apple allows the same customization on iOS by publicizing their private API, I wouldn't necessarily be against it there either. |
Was originally just implementing the now playable solution but I was discontent with
VideoPlayerManager
and had the intention to refactor it anyways, so I'm just doing that now.Very much copying solution from Apple sample app. These APIs are archaic and this is just the easiest.