Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Player Manager Refactor #1203

Draft
wants to merge 107 commits into
base: main
Choose a base branch
from
Draft

Conversation

LePips
Copy link
Member

@LePips LePips commented Aug 19, 2024

Was originally just implementing the now playable solution but I was discontent with VideoPlayerManager and had the intention to refactor it anyways, so I'm just doing that now.

Very much copying solution from Apple sample app. These APIs are archaic and this is just the easiest.

@LePips LePips changed the title Now Playable App Video Player Manager Refactor Aug 24, 2024
@JPKribs
Copy link
Member

JPKribs commented Aug 24, 2024

Out of curiosity, will part of this refactor include the TODO to move the playback reporting logic? I only ask because Native Player playback reporting seems to be hit or miss. Particularly when the app is closed instead of closing the player more gracefully in-app.

I was going to look at it but I can hold off if that's an area you are going to be interacting with.

@LePips
Copy link
Member Author

LePips commented Aug 24, 2024

Yes, my intention is to fix the playback reporting and some other discrepancies between the players with this as well.

@JPKribs
Copy link
Member

JPKribs commented Jan 1, 2025

I'm probably behind the curve here but I was looking at this today:

https://developer.apple.com/documentation/avkit/customizing-the-tvos-playback-experience

Do you think we have any appetite for this for the Native Player on tvOS or is the goal to make the AVKit implementation as minimal as possible for maintainability?

Not implying this should be part of this PR! Just thought I would ask before I started looking at this more seriously.

@LePips
Copy link
Member Author

LePips commented Jan 1, 2025

At least here, I only care about implementing the same capabilities on iOS and tvOS which mostly means only providing the additional metadata. However since tvOS does allow that additional customization with buttons I'm not necessarily against their implementation but I will not personally actively seek to implement them. If someday Apple allows the same customization on iOS by publicizing their private API, I wouldn't necessarily be against it there either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants