Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tvOS] ItemTypeLibraryViewModel - Implement FilterViewModel #1409

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

JPKribs
Copy link
Member

@JPKribs JPKribs commented Jan 25, 2025

Summary

I'm trying to get in the habit of doing more manageable / single item PRs. This one is the last step for #1407 before we start needing to have UI discussions.

This PR changes the ItemTypeLibraryViewModel and PagingViewModel. The primary change is the init for ItemTypeLibraryViewModel that accepts ItemFilterCollection as a parameter. This replaces the existing init and results in ItemTypeLibraryViewModel having a FilterViewModel. This enables the ability to perform filtering on the generic Shows / Movies.

I've tested this implementation works via #1407. I am splitting this out so we can get all the groundwork for filtering done now so we can hit the ground running when we have a plan for what we want that to look like. Additionally, this lets us confirm this implementation is done in the cleanest fashion possible without the clutter of other filtering components at the same time.

Copy link
Member

@LePips LePips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a while since I've looked at these and realize there is potential for a good amount of cleanup, like removing ItemTypeLibraryViewModel entirely, and some API improvements. I've added those comments.

@LePips LePips merged commit 35c39a8 into jellyfin:main Jan 26, 2025
4 checks passed
@JPKribs JPKribs deleted the tvOSItemTypeFilterViewModel branch January 26, 2025 21:11
@JPKribs JPKribs added enhancement New feature or request developer Developer facing issues labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Developer facing issues enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants