-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove native mode #925
base: master
Are you sure you want to change the base?
Remove native mode #925
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #925 +/- ##
=======================================
Coverage 21.90% 21.90%
=======================================
Files 63 63
Lines 8634 8631 -3
Branches 1587 1586 -1
=======================================
Hits 1891 1891
+ Misses 6722 6719 -3
Partials 21 21 ☔ View full report in Codecov by Sentry. |
I recently updated to jellyfin 10.10 and noticed the removal of the native mode by the server. Some movies do just not play using addon mode (can reproduce it reliably using large DoVi files) and thus addon mode is unusable for me. I hacked back native mode by editing the kodi addon and doing the path substitution there. Instead of removing this useful feature completely, it would be better to add a client setting allowing users to set the native path inside the kodi addon itself as proposed here. There's a lot of other people complaining about addon mode in the discussion as well |
Please dont remove native mode, my use case is 90% native mode when watching jellyfin at home with Kodi. The best file performance with jellyfin metadata. Is it possible to have native mode settings included in the addon settings? mapping entirely client-side like PlexKodiConnect |
Server support is getting removed in Jellyfin 10.10
See jellyfin/jellyfin#12446 for the 10.10 removal in server and jellyfin/jellyfin-web#5098 for the 10.9 removal in web.
See also jellyfin/jellyfin#11654 for some discussion around the 10.9 removal.
I was certain there was more on the topic somewhere on GitHub (I feel like there's a discussion thread missing), but it is quite possible most if not all of it was discussed only in chat (Matrix) and not properly documented on GitHub.
TODO:
— not much that could go wrong here, I'm just skipping the dialog and setting the config value directly
— add a way to silence the warning if so
— probably best left for later