Standardize bind IPs in ssdp and dlnahost #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set publisher uri to http so it wont be affected by published server uri
Remove . from friendlyname for identifying LG TVs
crobibero
approved these changes
Oct 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reported problem was that the plugin was not responding to ssdp:discover messages. After looking at this for a bit I found the plugin was using different ways for how the networking IPs were selected, in both the ssdp and the dlnahost. There was also a spot where, from what I understood, the bind IPs list was being looped through and listed twice. I'll admit I don't fully understand the UPNP spec yet, but it didn't make sense to have multiple criteria for how the adapters were being selected. This pr aligns both ssdp and dlnahost to build that list the same way. I think there is still some more work to do to refine the description.xml but myself and a few others in the thread listed below have tested this and are now seeing JF listed on their dlna browsers and report that the plugin is now responding properly to ssdp:discover messages.
Fixes #64