Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #91 - Support for Special episodes with Display order: Absolute #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

winterbird-code
Copy link

No description provided.

@winterbird-code
Copy link
Author

Maybe I should mention that I don't have a .net development environment, so this is completely untested; but reading the code the fix seemed simple enough.

@scampower3
Copy link
Member

As far as I can tell, in the v4 api, absolute order is aways season 1 and will not contain specials. Not sure if it works the same in the v3 api.

@winterbird-code
Copy link
Author

That's probably true for v3 as well, but this PR works around that client side.

Currently setting a series as Absolute ordered will make the plugin ignore any season information parsed from the filesystem (SXXEYY or Season X directories). Jellyfin will still sort for example the file S02E52 to the second season, but when probing TVDB it will ignore the season number and just ask for the absolute ordered episode 52.

In this PR I do an exception for that logic, so if jellyfin sees an episode in season 0 it will not probe for the absolute ordered episode number, but will fall back on asking for season 0 in aired ordered. This should make it possible to get metadata for specials even if the main series is absolute ordered. As I noted in issue #91 even without this jellyfin will still sort any season 0 episode as a special, it will just get the wrong metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants