Optimize Regex object usage for parameter validation #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure how to test this but the generated code looks ok to me |
|
sorry, not sure how to handle the modified generator. should i run openapi-generator:updateApiSpecStable and push that, or run generateSources and push that? |
Run the |
| package org.jellyfin.sdk.model | ||
|
|
||
|
|
||
| public object RegexValidator { |
There was a problem hiding this comment.
I don't want to introduce additional code generation that relies on existing classes. This is the main reason I didn't add the centralized regex validation myself yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a new object to store requested Regex objects for parameter validation. When a parameter needs regex validation, retrieve the appropriate Regex from this object instead of creating a new one.
Resolves #864