You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes
This PR allows the client to request and render native PGS subtitle streams without transcoding. PGS is a graphical subtitle format. The subtitles are rendered locally by the client on-top of the video element.
This adds a new dependency libpgs-js. I just created this library for the Jellyfin project. If desired, you can fork it into the https://github.com/jellyfin domain.
@ferferga Yes, it is working just fine.
Like the default web interface I would like to add a opt-in option in the subtitle settings. However, I had no time to look into the setting menu in vue yet. Maybe this weekend.
@Arcus92 The subtitle settings are being worked on in #2360
After your perf improvements in your library, is there any good reason for keeping the opt-in setting for rendering? (I'd say it should be opt-out in Vue as well, given this client targets evergreen browsers and modern platforms, unlike web).
It should be fine performance wise. I haven't tested different server architectures yet. Ripping .sup files from the source is an intensive task. Worst case ffmpeg could run out of memory or cache disk space and block playback or crash the server. Currently this is just my unfounded fear. For web, I just wanted to be extra safe because this a brand new feature.
Since vue is already experimental we could just enable it - with your permission - and wait for some feedback. Best case no one will notice the difference.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR allows the client to request and render native PGS subtitle streams without transcoding. PGS is a graphical subtitle format. The subtitles are rendered locally by the client on-top of the video element.
This adds a new dependency libpgs-js. I just created this library for the Jellyfin project. If desired, you can fork it into the https://github.com/jellyfin domain.
Related Pull Request (backend): jellyfin/jellyfin#12056
Related Pull Request (web): jellyfin/jellyfin-web#5688