Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instruction regarding connect to eks #3751

Merged
merged 1 commit into from
Jan 20, 2025
Merged

add instruction regarding connect to eks #3751

merged 1 commit into from
Jan 20, 2025

Conversation

msvticket
Copy link
Member

@msvticket msvticket commented Jan 3, 2025

Description

To simplify the module the terraform-aws-eks-jx module it doesn't run aws eks update-kubeconfig any more

Checklist:

  • I have mentioned the appropriate type(scope), as referenced here in the commit message and PR title for the semantic checks to pass.
  • I have signed off the commit, as per instructions mentioned here.
  • Any dependent changes have already been merged.

@jenkins-x-bot
Copy link
Contributor

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated.
We'll continue to update you through PRs as we progress. Please check #8589 for further information.

@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview jenkins-x-jx-docs-pr-3751 here

Copy link

sonarqubecloud bot commented Jan 3, 2025

@msvticket msvticket changed the title fix: add instruction regarding connect to eks add instruction regarding connect to eks Jan 3, 2025
@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview jenkins-x-jx-docs-pr-3751 here

1 similar comment
@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview jenkins-x-jx-docs-pr-3751 here

@msvticket
Copy link
Member Author

/approve

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot
Copy link
Contributor

⭐ PR built and available in a preview jenkins-x-jx-docs-pr-3751 here

@jenkins-x-bot jenkins-x-bot merged commit 9ed0551 into main Jan 20, 2025
4 checks passed
@jenkins-x-bot jenkins-x-bot deleted the eks-connect branch January 20, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants