Make Pipeline jobs get dependency changes #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated DependencyChangesAggregator to use Run's instead of AbstractBuild's so that it could be used with WorkflowRun's. Added functionality in AllChangesWorkflowAction to get changes from a WorkflowRun's changed dependencies (though only including AbstractBuilds for now since Fingerprinter.FingerprintAction only supports that).
|
@pskumar448 Not sure who is maintaining this plugin now, but see that you merged the last few pull requests. Could you take a look at this one? It is touching the classes that you added previously as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a need to see dependency changes in Pipeline jobs that have used fingerprinted files from other jobs, something that wasn't implemented in the Pipeline support, as it would simply give you the changes since the previous build of the current job.
Updated DependencyChangesAggregator to use Run's instead of AbstractBuild's
so that it could be used with WorkflowRun's.
Added functionality in AllChangesWorkflowAction to get changes from a WorkflowRun's
changed dependencies (though only including AbstractBuilds for now since
Fingerprinter.FingerprintAction only supports that).