Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pvs studio refactoring #1090

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Pvs studio refactoring #1090

merged 2 commits into from
Sep 13, 2024

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Sep 13, 2024

ErrorProne detected a design problem that should be fixed.

After this change all ErrorProne warnings will be fixed 🎉

@uhafner uhafner added the internal Internal changes without user or API impact label Sep 13, 2024
Copy link

☀️   Quality Monitor

   🚦   Tests: 100 % successful (✔️ 1289 passed, 🙈 2 skipped)
   〰️   Line Coverage: 94% (417 missed lines)
   ➰   Branch Coverage: 87% (264 missed branches)
   CheckStyle   CheckStyle: No warnings
   PMD   PMD: No warnings
   SpotBugs   SpotBugs: No warnings

Created by Quality Monitor v1.9.0 (#00b9b1a). More details are shown in the GitHub Checks Result.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.55%. Comparing base (8623542) to head (6a1a02a).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
.../analysis/parser/pvsstudio/PlogMessagesReader.java 78.57% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1090      +/-   ##
============================================
- Coverage     90.56%   90.55%   -0.01%     
+ Complexity     2317     2311       -6     
============================================
  Files           357      357              
  Lines          6568     6566       -2     
  Branches        676      676              
============================================
- Hits           5948     5946       -2     
  Misses          417      417              
  Partials        203      203              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner merged commit 40fd342 into main Sep 13, 2024
31 of 33 checks passed
@uhafner uhafner deleted the pvs-studio-refactoring branch September 13, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal changes without user or API impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant