Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sarif report: allow file paths in file URI scheme #1102

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

theKBro
Copy link

@theKBro theKBro commented Nov 4, 2024

see https://issues.jenkins.io/browse/JENKINS-73933

file paths in file uri scheme are converter to normal paths

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@KalleOlaviNiemitalo
Copy link

Does this work with % encoding in file: URLs?

@theKBro
Copy link
Author

theKBro commented Nov 4, 2024

If an exception occurs it falls back to the old value

@KalleOlaviNiemitalo
Copy link

I meant, if the SARIF file has "file:///dir/%E2%82%AC", then does this translate it to "/dir/%E2%82%AC" or to "/dir/€"?

@theKBro
Copy link
Author

theKBro commented Nov 4, 2024

I added test data to the testcase to clarify this -> its getting translated

@theKBro
Copy link
Author

theKBro commented Nov 4, 2024

current solution seems to work under windows only...
any proposal how to improve the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants