Add category and type to code duplication issues

[emouty]

Testing done

I have noticed that there were no category nor type on cpd issues, which impact their integration with other tools.
In the category tab on Jenkins, it render a blank line which make them non clickable.

In the type tab, they are rendered with a - and gathered with all the other categorized issues.

And in the issue tab they are not easily identifiable without category nor type

So I proposed to set for all cpd issues a category CPD and for type CodeDuplication

Submitter checklist

Beta Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

[codecov]

Codecov Report

Merging #939 (f90c316) into master (a137c72) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #939   +/-   ##
=========================================
  Coverage     92.91%   92.92%           
  Complexity     2338     2338           
=========================================
  Files           345      345           
  Lines          6495     6499    +4     
  Branches        672      672           
=========================================
+ Hits           6035     6039    +4     
  Misses          262      262           
  Partials        198      198           

Files Changed	Coverage Δ
.../hafner/analysis/parser/dry/AbstractDryParser.java	90.90% <100.00%> (+0.43%)	⬆️
...u/hm/hafner/analysis/parser/dry/cpd/CpdParser.java	93.33% <100.00%> (+0.22%)	⬆️
...analysis/parser/dry/dupfinder/DupFinderParser.java	95.34% <100.00%> (+0.11%)	⬆️
...afner/analysis/parser/dry/simian/SimianParser.java	93.10% <100.00%> (+0.24%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[uhafner]

I wonder if we should better implement that in the warnings plug-in and convert all empty types and categories by default to a „-„? The dash is used for other empty elements as well.

On the other hand, a category for duplications in the analysis model would not hurt. But a category and type seems to be redundant for me. What do you think?

[emouty]

Yes, it could be nice to have a dash for empty categories on warning ng. that could be useful also for other parsers.

I know it seems redundant to have a category and a type for cpd duplication on the issue tab, but for the type tab and the category tab, that would be helpful to distinguish them from other uncategorized issues or not typed issues.

If we need to choose, I think setting the category would be better as for now there is no default category for uncategorized issues.

[uhafner]

Ok, then let us add these values.

[uhafner]

Move the category to

analysis-model/src/main/java/edu/hm/hafner/analysis/parser/dry/AbstractDryParser.java

Line 83 in a137c72

issueBuilder.setMessage("Found duplicated code.");

[uhafner]

I would prefer to set the category to „Code Duplication“.

[uhafner]

This is not yet addressed. Can't this be moved to the parent class?

[uhafner]

And „Code Duplication“ reads better than CamelCase.

[emouty]

My bad I missed that one

[emouty]

Should be good now.
I replaced buildAndClean() by build() in SimianParser and DupFinderParser otherwise from the second iteration in the duplication.getBlocks() loop you would loose the consolidated fields (message and category) from the AbstractDryParser.
Didn't needed to do it in CPDParser as it already used build().

[uhafner]

And use „CPD“ as type here. It would be nice to set the type for the other two parsers as well.

[uhafner]

Thanks!