-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-63580] Update regex for msbuild to recognize linker warnings #952
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the regular expression actually is degenerated, too many options have been added year by year. I tried to fix that a little bit, and now your test works :-)
(Maybe it makes sense to start from scratch sometimes... But for now the PR is ready to be integrated, thanks!)
SUPPORTED-FORMATS.md
Outdated
@@ -1,4 +1,4 @@ | |||
<!--- DO NOT EDIT -- Generated at 2023-09-20T10:55:02.107301 - Run the `main` method of `ParserRegistry` to regenerate after changing parsers -- DO NOT EDIT ---> | |||
<!--- DO NOT EDIT -- Generated at 2023-10-03T10:06:45.445947 - Run the `main` method of `ParserRegistry` to regenerate after changing parsers -- DO NOT EDIT ---> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please remove that file from the change list?
Codecov Report
@@ Coverage Diff @@
## master #952 +/- ##
============================================
+ Coverage 92.94% 93.07% +0.13%
- Complexity 2368 2371 +3
============================================
Files 347 347
Lines 6592 6588 -4
Branches 686 686
============================================
+ Hits 6127 6132 +5
+ Misses 263 256 -7
+ Partials 202 200 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thank you very much for making changes to my test, I focused on the parsing problem (on the first assert) and did not bring the test itself to the proper form. Upd: okay, as I see on the hactoberfest page, this PR has already been accepted and is being processed 😅 |
Ok, thanks, released in https://github.com/jenkinsci/analysis-model/releases/tag/v11.9.0 |
Closes JENKINS-63580
Testing done
Submitter checklist