-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for proxy authentication fill-in added #53
base: master
Are you sure you want to change the base?
Conversation
@imod |
@sealor its not required per se, but it helps a lot to get more context about the issue you try to solve |
It would be great to get this merged |
@sealor I'm sure this will work, but from a users point of view, this is a hidden feature. To make this more visible (and clean), there should probably be a "Proxy Credentials" section beside the "Server Credentials" Section when editing a configuration. this comes even more apparent when you look at the way this would look when creating a configfile with the
|
487ac7c
to
bf230be
Compare
@imod Now, there is a "Proxy Credentials" section beside the "Server Credentials" section. The new feature behaves exactly like the other one. |
@MRamonLeon I myself do not need this feature anymore because I now use another solution. But in my opinion this feature would be very helpful for others. |
@sealor I was scrubbing a bit and I probably misunderstood your last comment and taking into account the last time it had activity I closed it. Happy to reopen if it's still interesting. I can't commit to any review ATM though. |
@MRamonLeon |
When providing maven settings and global maven settings the proxy authentication is now also filled in using the Jenkins credentials if available.
The feature is similar to the authentication replacements for maven server configurations.
See https://maven.apache.org/settings.html