Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to changes to owner field in GitHub App Credentials #107

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dwnusbaum
Copy link
Member

This PR provides the minimal changes needed to avoid calling deprecated GitHubAppCredentials methods after jenkinsci/github-branch-source-plugin#822. It does not attempt to make the new repositoryAccessStrategy or defaultPermissionStrategy fields fully configurable.

Testing done

Untested apart from running mvn clean verify

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant