Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for ItemInfo class #433

Closed
wants to merge 6 commits into from

Conversation

yashpal2104
Copy link
Contributor

Testing done

Add test for ItemInfo class

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did

@github-actions github-actions bot added the tests Automated test addition or improvement label Jan 5, 2025
@yashpal2104
Copy link
Contributor Author

@MarkEWaite would like your thoughts on this

@MarkEWaite
Copy link
Contributor

As a general pattern, most Jenkins plugin maintainers don't review draft pull requests. A pull request is usually marked as draft by the submitter because they are not ready for review.

Since you asked for my feedback, I checked the CI job. The pull request fails to compile. You need to fix the compilation before I'll spend time reviewing the pull request in any other way.

@yashpal2104
Copy link
Contributor Author

Hey @MarkEWaite,
I know it is too much to task but addressing the problem here clearly, I have written the test class but the object I am using (i.e item) in my tests for assertions is only going to be used when I implement an abstract class of hudson.model.Queue.Item which is inside hudson.model.Queue hence the compiling error is occuring when building, if you can help me implement the methods enter(Queue q) and leave(Queue q) which are abstract methods in the abstract class hudson.model.Queue.Item, I have tried to solve this but I was unsuccesful in implementing them it will be a breakthrough if someone helps me in implementing these in my test class.
I also have another solution but that includes refactoring the Queue.java class in the jenkinsci repository and I am not inclined towards it.

@yashpal2104 yashpal2104 closed this by deleting the head repository Jan 23, 2025
@yashpal2104 yashpal2104 mentioned this pull request Jan 23, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants