Use existing view in the job group test

[MarkEWaite]

Use existing view in the job group test

Restore a loss that I caused in the original test created by @yashpal2104. Thanks very much to @yashpal2104 for detecting the loss!

@yashpal2104 I'd love to have your review to be sure that I corrected my earlier mistakes.

Expand tests for existing and non-existing views.

Amends #437 to correct mistakes that I made while reviewing that pull request.

Testing done

Confirmed that test pass on my Linux computer.

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[yashpal2104]

Yes, I think the method works about just right. Thank you 😊
Also can you tell me how do I effectively review the changes made by others pulling them locally and then reviewing it or only the maintainers have that authority, because this time I just copy pasted the changes locally and then reviewed it

[MarkEWaite]

Can you tell me how do I effectively review the changes made by others pulling them locally and then reviewing it or only the maintainers have that authority, because this time I just copy pasted the changes locally and then reviewed it

When I have questions about the code that I'm reviewing, I use the gh command line utility to pull the changes locally and build them. In this case, it would be gh pr checkout 440. Then I can run the tests in my debugger, set breakpoints, and watch the behavior as I make changes.

The gh utility is also helpful for creating pull requests. I use gh pr create --title "My title"

[yashpal2104]

Can you tell me how do I effectively review the changes made by others pulling them locally and then reviewing it or only the maintainers have that authority, because this time I just copy pasted the changes locally and then reviewed it

When I have questions about the code that I'm reviewing, I use the gh command line utility to pull the changes locally and build them. In this case, it would be gh pr checkout 440. Then I can run the tests in my debugger, set breakpoints, and watch the behavior as I make changes.

The gh utility is also helpful for creating pull requests. I use gh pr create --title "My title"

Thank you so much for sharing this knowledge