- fixes [JENKINS-64062] (#47)

jenkinsci · Nov 4, 2020 · b545dc8 · b545dc8
1 parent c7aaf2a
commit b545dc8
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 4 deletions.
diff --git a/pom.xml b/pom.xml
@@ -18,8 +18,6 @@
     <java.level>8</java.level>
     <hpi.compatibleSinceVersion>2.0.0</hpi.compatibleSinceVersion>
 
-    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-
     <maven.version>3.6.3</maven.version>
     <maven-resolver.version>1.4.2</maven-resolver.version>
 

diff --git a/src/main/java/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterValue.java b/src/main/java/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterValue.java
@@ -15,7 +15,7 @@ public class VersionParameterValue extends StringParameterValue {
     private final String repositoryId;
 
     public VersionParameterValue(String name, String description, String repositoryId, String groupId, String artifactId, String value) {
-        super(name, description, value);
+        super(name, value, description);
 
         this.groupId = groupId;
         this.artifactId = artifactId;

diff --git a/...est/java/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterDefinitionTest.java b/...est/java/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterDefinitionTest.java
@@ -52,9 +52,25 @@ public void testGetVersions() throws Exception {
         assertEquals("LATEST", versions.get(2));
     }
 
+    @Test
+    public void testGetVersionParameterValue() {
+        VersionParameterDefinition definition = createVersionParameterDefinition();
+        definition.setRepositoryId("repositoryId");
+
+        VersionParameterValue value = (VersionParameterValue) definition.createValue("version");
+
+        assertEquals("name", value.getName());
+        assertEquals("version", value.getValue());
+        assertEquals("desc", value.getDescription());
+
+        assertEquals("groupId", value.getGroupId());
+        assertEquals("artifactId", value.getArtifactId());
+        assertEquals("repositoryId", value.getRepositoryId());
+    }
+
     @SuppressWarnings("serial")
     private VersionParameterDefinition createVersionParameterDefinition() {
-        return new VersionParameterDefinition("name", null, "groupId", "artifactId") {
+        return new VersionParameterDefinition("name", "desc", "groupId", "artifactId") {
             @Override
             Aether createAether() {
                 return mockAether;