feat: Improved circular import error message

jespertheend · Feb 2, 2023 · 8584877 · 8584877
1 parent acb632f
commit 8584877
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/src/ImportResolver.js b/src/ImportResolver.js
@@ -379,7 +379,7 @@ ${getRelativePath(this.#importMeta, url)}
 					throw new Error(
 						`Circular imports are not supported:
 ${importFileNames}
-Consider passing one of the following paths to \`importer.makeReal()\`:
+Consider faking or passing one of the following paths to \`importer.makeReal()\`:
 ${importPathsWithoutDuplicates.join("\n")}`,
 					);
 				}

diff --git a/src/getRelativePath.js b/src/getRelativePath.js
@@ -8,7 +8,7 @@ import { posix } from "https://deno.land/[email protected]/path/mod.ts";
 export function getRelativePath(pathA, pathB) {
 	let a = posix.fromFileUrl(pathA);
 	if (!a.endsWith("/")) {
-		a = posix.dirname(a)
+		a = posix.dirname(a);
 	}
 	const b = posix.fromFileUrl(pathB);
 	let rel = posix.relative(a, b);

diff --git a/test/integration/circular.test.js b/test/integration/circular.test.js
@@ -31,7 +31,7 @@ Deno.test({
 				Error,
 				`Circular imports are not supported:
 A.js -> B.js -> A.js
-Consider passing one of the following paths to \`importer.makeReal()\`:
+Consider faking or passing one of the following paths to \`importer.makeReal()\`:
 ./A.js
 ./B.js`,
 			);
@@ -76,7 +76,7 @@ Deno.test({
 				Error,
 				`Circular imports are not supported:
 A.js -> B.js -> C.js -> A.js
-Consider passing one of the following paths to \`importer.makeReal()\`:
+Consider faking or passing one of the following paths to \`importer.makeReal()\`:
 ./A.js
 ./B.js
 ./C.js`,
@@ -126,7 +126,7 @@ Deno.test({
 				Error,
 				`Circular imports are not supported:
 A.js -> B.js -> C.js -> D.js -> B.js
-Consider passing one of the following paths to \`importer.makeReal()\`:
+Consider faking or passing one of the following paths to \`importer.makeReal()\`:
 ./A.js
 ./B.js
 ./C.js
@@ -173,7 +173,7 @@ Deno.test({
 				Error,
 				`Circular imports are not supported:
 A.js -> B.js -> C.js -> A.js
-Consider passing one of the following paths to \`importer.makeReal()\`:
+Consider faking or passing one of the following paths to \`importer.makeReal()\`:
 ./root/A.js
 ./root/scripts/B.js
 ./root/C.js`,
@@ -311,7 +311,7 @@ Deno.test({
 				Error,
 				`Circular imports are not supported:
 A.js -> B.js -> D.js -> F.js -> D.js
-Consider passing one of the following paths to \`importer.makeReal()\`:
+Consider faking or passing one of the following paths to \`importer.makeReal()\`:
 ./A.js
 ./B.js
 ./D.js
@@ -388,7 +388,7 @@ Deno.test({
 				Error,
 				`Circular imports are not supported:
 A.js -> B.js -> A.js
-Consider passing one of the following paths to \`importer.makeReal()\`:
+Consider faking or passing one of the following paths to \`importer.makeReal()\`:
 ./A.js
 ../B/B.js`,
 			);