Add a menu item to delete both local and remote branch at once

[stefanhaller]

• PR Description

Add a menu item to delete both local and remote branch at once.

• Please check if the PR fulfills these requirements

• Cheatsheets are up-to-date (run go generate ./...)
• Code has been formatted (see here)
• Tests have been added/updated (see here for the integration test guide)
• Text is internationalised (see here)
• If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
• Docs have been updated if necessary
• You've read through your own file changes for silly mistakes etc

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for e181de11	✅ 91.67%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (e181de1)	Report Missing	Report Missing	Report Missing
Head commit (1ab70ec)	50586	43484	85.96%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#3916)	96	88	91.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[stefanhaller]

I decided to put up only a single confirmation ("are you sure you want to delete both branches"). If the local branch is not merged, I append the warning about this below in the same popup. I like this better than putting up a separate popup for this after the first one, but I can change it if you disagree.

[jesseduffield]

LGTM, great work. I agree about combining the messages: it makes for fewer keypresses

[philbarto]

Hey @stefanhaller this may be a stupid question but you just press b when on a branch you're not checked out on to delete the local and remote branch, correct? That's what I could gather by reading the code but that doesn't do anything on my machine.

[mark2185]

@philbarto judging by the code it looks like it's a menu item, which is probably the delete menu behind d. One of the options in there should be under b.

[philbarto]

@mark2185 Yeah that's what I was thinking too, although I don't see the b option when trying to delete a branch

[mark2185]

@philbarto can't check exact dates on my phone, but check if this wasn't merged after v0.44.1 was released.

If you can build master from source, you should have it.