Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Fix demo service account #82

Merged

Conversation

ltagliamonte-dd
Copy link
Contributor

Signed-off-by: Luigi Tagliamonte [email protected]

Signed-off-by: Luigi Tagliamonte <[email protected]>
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Jul 30, 2019
@jetstack-bot jetstack-bot requested a review from simonswine July 30, 2019 17:07
@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 30, 2019
@jetstack-bot
Copy link
Contributor

Hi @ltagliamonte-dd. Thanks for your PR.

I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ltagliamonte-dd
Copy link
Contributor Author

/assign @JoshVanL

@JoshVanL
Copy link
Contributor

Thanks for that 😄

/approve
/lgtm
/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2019
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL, ltagliamonte-dd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2019
@jetstack-bot jetstack-bot merged commit ba07702 into jetstack:master Jul 31, 2019
@jetstack-bot
Copy link
Contributor

@ltagliamonte-dd: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kube-oidc-proxy-e2e-v1-15 7ddb8d2 link /test pull-kube-oidc-proxy-e2e-v1-15

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ltagliamonte-dd ltagliamonte-dd deleted the fix_demo_service_account branch July 31, 2019 15:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants