Fixed SHA256 Hashing result. Closes #47

jezzsantos · Aug 16, 2024 · 3042b31 · 3042b31
1 parent ba1b752
commit 3042b31
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/src/AncillaryInfrastructure/Api/3rdParties/MailgunApi.cs b/src/AncillaryInfrastructure/Api/3rdParties/MailgunApi.cs
@@ -86,7 +86,7 @@ internal static Result<Error> AuthenticateRequest(IRecorder recorder, ICallerCon
             return Error.NotAuthenticated();
         }
 
-        var signature = $"sha1={parameters.Signature}";
+        var signature = $"sha256={parameters.Signature}";
         var text = $"{parameters.Timestamp}{parameters.Token}";
 
         var signer = new HMACSigner(text, webhookSigningKey);

diff --git a/src/Infrastructure.Web.Api.Common.UnitTests/Extensions/HttpRequestExtensionsSpec.cs b/src/Infrastructure.Web.Api.Common.UnitTests/Extensions/HttpRequestExtensionsSpec.cs
@@ -101,7 +101,7 @@ public void WhenSetHmacAuthWithEmptyRequest_ThenSetsSignatureHeader()
         message.SetHMACAuth(request, "asecret");
 
         message.Headers.GetValues(HttpConstants.Headers.HMACSignature).Should().OnlyContain(hdr =>
-            hdr == "sha1=f8dbae1fc1114a368a46f762db4a5ad5417e0e1ea4bc34d7924d166621c45653");
+            hdr == "sha256=f8dbae1fc1114a368a46f762db4a5ad5417e0e1ea4bc34d7924d166621c45653");
     }
 
     [Fact]
@@ -113,7 +113,7 @@ public void WhenSetHmacAuthWithPopulatedRequest_ThenSetsSignatureHeader()
         message.SetHMACAuth(request, "asecret");
 
         message.Headers.GetValues(HttpConstants.Headers.HMACSignature).Should().OnlyContain(hdr =>
-            hdr == "sha1=efab63816eb3c3ab799dfd64e717865116f7aa1547177293ec6598fe3cc8e3de");
+            hdr == "sha256=efab63816eb3c3ab799dfd64e717865116f7aa1547177293ec6598fe3cc8e3de");
     }
 
     [Fact]

diff --git a/src/Infrastructure.Web.Api.Common.UnitTests/HMACSignerSpec.cs b/src/Infrastructure.Web.Api.Common.UnitTests/HMACSignerSpec.cs
@@ -25,7 +25,7 @@ public void WhenSignAndRequestIsHollow_ThenReturnsSignature()
 
             var result = signer.Sign();
 
-            result.Should().Be("sha1=f8dbae1fc1114a368a46f762db4a5ad5417e0e1ea4bc34d7924d166621c45653");
+            result.Should().Be("sha256=f8dbae1fc1114a368a46f762db4a5ad5417e0e1ea4bc34d7924d166621c45653");
         }
 
         [Fact]
@@ -38,7 +38,7 @@ public void WhenSignAndRequestIsPopulated_ThenReturnsSignature()
 
             var result = signer.Sign();
 
-            result.Should().Be("sha1=5ac3c7a7378d5f293359720f1bf64cfcbfbf672b61640121a11526638a57a2c5");
+            result.Should().Be("sha256=5ac3c7a7378d5f293359720f1bf64cfcbfbf672b61640121a11526638a57a2c5");
         }
 
         [Fact]

diff --git a/src/Infrastructure.Web.Api.Common/HMACSigner.cs b/src/Infrastructure.Web.Api.Common/HMACSigner.cs
@@ -11,7 +11,7 @@ namespace Infrastructure.Web.Api.Common;
 /// </summary>
 public class HMACSigner
 {
-    private const string SignatureFormat = @"sha1={0}";
+    private const string SignatureFormat = @"sha256={0}";
     private static readonly Encoding SignatureEncoding = Encoding.UTF8;
     private readonly byte[] _data;
     private readonly string _secret;