Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkin: fix function module processing type #115

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

palubaj
Copy link
Collaborator

@palubaj palubaj commented Aug 29, 2023

Upon checkin of function group, take into account REMOTE_CALL settings. To change the processing type of function module, first it needs to be created. Afterwards its attributes can be edited.

@palubaj palubaj requested a review from jfilak August 29, 2023 14:07
Upon checkin of function group, take into account REMOTE_CALL settings.
To change the processing type of function module, first it needs to be
created. Afterwards its attributes can be edited.

---v2
Fix lint errors by moving the creation of function module to separate
function.
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (77ab5ab) 98.24% compared to head (bea776a) 98.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files          82       82           
  Lines        8261     8269    +8     
=======================================
+ Hits         8116     8124    +8     
  Misses        145      145           
Files Changed Coverage Δ
sap/cli/checkin.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfilak jfilak merged commit 2839463 into jfilak:master Aug 29, 2023
4 checks passed
@jfilak
Copy link
Owner

jfilak commented Aug 29, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants