strust identities #131
Merged
strust identities #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the code from getlocale is lower cased and so I believe users interchange uppercase and lowercase codes without thinking, so the code should be user friendly.
To avoid the need to implement the parsing and checking everywhere where we may need it. We want to use current system locale for getting default language code where language is required.
If the language is not give ABAP system ignores the description completely. This patch forces consumers to provide language if they provide description. However, to simplify their lives, lets assume that if the language code is not given, they write in the language of their current system locale.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #131 +/- ##
=======================================
Coverage 98.46% 98.47%
=======================================
Files 87 87
Lines 8622 8637 +15
=======================================
+ Hits 8490 8505 +15
Misses 132 132 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.