Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

Out of repo settings #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cyisfor
Copy link
Contributor

@cyisfor cyisfor commented May 30, 2020

So we don't accidenally put passwords under revision control.

Files that contain private information like passwords, secrets, and host names shouldn't be under revision control.
@jfmcbrayer
Copy link
Owner

Hi, thank you for all of your help. I'm currently -1 on this patch, though I like the idea. I feel like using XDG directories is too focused on the use case of an individual running it as a client on their personal computer, rather than for people running public servers. I think the most Django-ish way of doing it would be to look for a file like 'local_settings.py' in the same folder as settings.py.

@lvm
Copy link

lvm commented Aug 1, 2020

I'm just a regular user so my opinion doesn't matter that much on this topic... but agree with @jfmcbrayer. Something closer to https://12factor.net/config is much more preferable than storing settings on XDG Directories.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants