merge eslint-plugin-better Fixes #30 #32
Conversation
Allows rule users to use a slower, but more accurate must-return rule: eg, idmitriev/eslint-plugin-better#3
graingert
force-pushed
the
merge-plugin-better
branch
2 times, most recently
from
266b281 to
8ce009c
Compare
|
@idmitriev @jfmengels thoughts? |
|
@nickmccurdy ^ |
graingert
force-pushed
the
merge-plugin-better
branch
from
8ce009c to
8b8fa79
Compare
graingert
force-pushed
the
merge-plugin-better
branch
from
8b8fa79 to
361f228
Compare
graingert
force-pushed
the
merge-plugin-better
branch
from
70afb01 to
64fb977
Compare
|
I've invited you all to contribute to https://github.com/eslint-plugin-cleanjs/eslint-plugin-cleanjs which includes the ruleset from eslint-config-cleanjs (excluding eslint-plugin-import) and this PR. |
|
@jfmengels Ideally I'd like to merge back into eslint-plugin-fp, because it has a much better name on npm. |
There was a problem hiding this comment.
I just read this, looks great thanks! I only skimmed the new rule source files but I'm assuming they're the same as eslint-plugin-better in master. It's ready to merge as far as I'm aware.
I also noticed that none of the new rules are marked as recommended. I think this is good for transitional purposes, though it would be great to change the default recommended rules and draft a major release after this is merged.
|
Any update on this? |
|
@nickmccurdy looks like it's started to conflict |
|
@jfmengles can I get access to this repo and npm publish? |
|
@graingert I give them to you quite a while ago 🤔 |
|
Oh really ok, I'll sort all this out asap then |
|
It would be nice to see docs for the new rules, in the same style as |
Fixes #30