Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all repos if non given #285

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add all repos if non given #285

wants to merge 4 commits into from

Conversation

derhecht
Copy link

like cleanup script

same behavior as for cleanup script
Use all repositories if non given
@elioengcomp
Copy link
Contributor

Hi @derhecht , thank you for your contribution.

I'm not very comfortable with adding behavior when some configuration value is missing. I think It can hide configuration mistakes and provide an undesired result. This is specially important in cases like this where we are deleting things from the server.

I would like to suggest the usage of a key word, something like ALL, to be used by the user to set the repo/path list parameter when looking for the behavior added by you. We also need to document that as a possible configuration value in the README file.

@calvinpark
Copy link

Excellent change! Picked up for my RT

@derhecht
Copy link
Author

Hi @derhecht , thank you for your contribution.

I'm not very comfortable with adding behavior when some configuration value is missing. I think It can hide configuration mistakes and provide an undesired result. This is specially important in cases like this where we are deleting things from the server.

I would like to suggest the usage of a key word, something like ALL, to be used by the user to set the repo/path list parameter when looking for the behavior added by you. We also need to document that as a possible configuration value in the README file.

Hi @elioengcomp may have a look at this approach?

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2020

CLA assistant check
All committers have signed the CLA.

@derhecht
Copy link
Author

ok, added email address to my account, signed CLA, recheck seems not to work...

@derhecht
Copy link
Author

got it. finally.

@yashprit-jfrog
Copy link
Collaborator

@derhecht this PR is open for long time. Are you still open to take this PR to closer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants