Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Yarn Version and Improve Error Messaging for Unsupported Versions #2866

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

fluxxBot
Copy link
Collaborator

@fluxxBot fluxxBot commented Feb 10, 2025

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

depends on:-

  1. Add functionality to check the supported Yarn package manager version jfrog-cli-core#1347
  2. Introduce Validation for Supported Yarn Versions jfrog-cli-artifactory#44

@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Feb 11, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 11, 2025
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Feb 11, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 11, 2025
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Feb 11, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 11, 2025
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Feb 13, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 13, 2025
@EyalDelarea EyalDelarea added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Feb 13, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 16, 2025
Copy link
Contributor

@EyalDelarea EyalDelarea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the test cases to address new changes made to the other PRs.

Also i'm editing the PR title, as CLI pull requests will appear in the release notes of the CLI, and this is the place to notify users about the improvement that has been introduced here. ( also by the core and artifactory )

npm_test.go Show resolved Hide resolved
@EyalDelarea EyalDelarea changed the title Tests for Restricting user to use yarn v4 Validate Yarn Version and Improve Error Messaging for Unsupported Versions Feb 17, 2025
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Feb 18, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 18, 2025
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Feb 18, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 18, 2025
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Feb 18, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 18, 2025
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Feb 18, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 18, 2025
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Feb 18, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants