Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme.md #440

Closed
wants to merge 1 commit into from
Closed

Update readme.md #440

wants to merge 1 commit into from

Conversation

Or-Geva
Copy link
Contributor

@Or-Geva Or-Geva commented Nov 8, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

@Or-Geva Or-Geva requested a review from eyalbe4 November 8, 2023 15:40
@Or-Geva Or-Geva added the ignore for release Automatically generated release notes label Nov 8, 2023
eyalbe4
eyalbe4 requested changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment •
edited by Or-Geva
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I'll be soon creating a PR for removing the documentation content from the README, and adding a reference to the new documentation site, I recommend closing this PR.

@Or-Geva Or-Geva closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Or-Geva @eyalbe4