Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
jfversluis authored Apr 26, 2024
1 parent afacf2d commit b9172b5
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ public interface IAudioRecorder
///<param name="options">The audio recording options.</param>
public Task StartAsync(string filePath, AudioRecordingOptions options) => Task.CompletedTask;


///<Summary>
/// Stop recording and return the <see cref="IAudioSource"/> instance with the recording data.
///</Summary>
Expand Down
6 changes: 0 additions & 6 deletions src/Plugin.Maui.Audio/AudioRecordingOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ public class AudioRecordingOptions
public const ChannelType DefaultChannels = ChannelType.Mono;
public const BitDepth DefaultBitDepth = BitDepth.Pcm16bit;
public const Encoding DefaultEncoding = Encoding.LinearPCM;



/// <summary>
/// Sample rate of the audio recording.
/// 44,100Hz is currently the only rate that is guaranteed to work on all devices on Android, <see href="https://developer.android.com/reference/android/media/AudioRecord.html">Android audio record documentation</see>
Expand All @@ -47,7 +44,4 @@ public class AudioRecordingOptions
/// Gets or sets whether the functionality will thrown an exception if the configured recording options are not supported.
/// </summary>
public bool ThrowIfNotSupported { get; set; } = false;



}

0 comments on commit b9172b5

Please sign in to comment.