Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix android crash Dispose() call in PlaybackEnded event #122

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Fix android crash Dispose() call in PlaybackEnded event #122

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d63b88
Fix android crash Dispose() call in PlaybackEnded event
ndegheselle Aug 5, 2024
1dfe2fc
Moved PlaybackEnded.Invoke at the end of OnPlaybackEnded on android
ndegheselle Aug 26, 2024
9d7ea43
Merge branch 'main' into main
ndegheselle Aug 27, 2024
a80861d
Merge branch 'main' into main
bijington Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Plugin.Maui.Audio/AudioPlayer/AudioPlayer.android.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,6 @@ void SetVolume(double volume, double balance)

void OnPlaybackEnded(object? sender, EventArgs e)
{
PlaybackEnded?.Invoke(this, e);

isPlaying = player.IsPlaying;

//this improves stability on older devices but has minor performance impact
Expand All @@ -318,6 +316,8 @@ void OnPlaybackEnded(object? sender, EventArgs e)
player.Stop();
player.Prepare();
}

PlaybackEnded?.Invoke(this, e);
}

protected virtual void Dispose(bool disposing)
Expand All @@ -330,6 +330,7 @@ protected virtual void Dispose(bool disposing)
if (disposing)
{
player.Completion -= OnPlaybackEnded;
player.Reset();
player.Release();
player.Dispose();
DeleteFile(cachePath);
Expand Down
Loading