Fix NaN json serialization in Aim GetRunMetrics (G-Research#439)

jgiannuzzi · Oct 16, 2023 · 1143665 · 1143665
1 parent b7632fc
commit 1143665
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/pkg/api/aim/runs.go b/pkg/api/aim/runs.go
@@ -193,18 +193,19 @@ func GetRunMetrics(c *fiber.Ctx) error {
 	}
 
 	metrics := make(map[string]struct {
-		values []float64
+		values []*float64
 		iters  []int
 	}, len(metricKeys))
 	for _, m := range r.Metrics {
 		k := metrics[m.Key]
 
 		v := m.Value
+		pv := &v
 		if m.IsNan {
-			v = math.NaN()
+			pv = nil
 		}
 
-		k.values = append(k.values, v)
+		k.values = append(k.values, pv)
 		k.iters = append(k.iters, int(m.Iter))
 		metrics[m.Key] = k
 	}