Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHY] Get/Set modem #1294

Merged
merged 15 commits into from
Oct 26, 2024
Merged

[PHY] Get/Set modem #1294

merged 15 commits into from
Oct 26, 2024

Conversation

jgromes
Copy link
Owner

@jgromes jgromes commented Oct 26, 2024

This PR adds an interface to get and set modem type (LoRa, FSK or LR-FHSS) through PhysicalLayer. Needed for LoRaWAN to support FSK and LR-FHSS uplinks.

EDIT: Also drupped Arduino Uno from the CI build list, since the library is too large to build on a large portion of the examples.

@jgromes jgromes merged commit e44e9b4 into master Oct 26, 2024
29 checks passed
@jgromes jgromes deleted the set-modem branch October 26, 2024 15:49
@lyusupov
Copy link
Contributor

lyusupov commented Oct 29, 2024

Jan,
use of too much generic symbols here:
https://github.com/jgromes/RadioLib/blob/master/src/protocols/PhysicalLayer/PhysicalLayer.h#L138-L140

/*!
  \enum ModemType_t
  \brief Type of modem, used by setModem.
*/
enum ModemType_t {
  FSK = 0,
  LoRa,
  LRFHSS,
};

- causes namespace conflict with other software at build time

Could you, please, consider to replace it with more RadioLib specific names, such as:

/*!
  \enum ModemType_t
  \brief Type of modem, used by setModem.
*/
enum ModemType_t {
  RADIOLIB_FSK = 0,
  RADIOLIB_LoRa,
  RADIOLIB_LRFHSS,
};

Thank you!

jgromes added a commit that referenced this pull request Oct 29, 2024
@jgromes
Copy link
Owner Author

jgromes commented Oct 29, 2024

@lyusupov That's a good point actually, it's fixed in 4564d87 - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants