Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make RadioLib build compatible with Arduino Core for CH32 #1310

Closed
wants to merge 1 commit into from

Conversation

lyusupov
Copy link
Contributor

@lyusupov lyusupov commented Nov 4, 2024

Arduino Core for CH32 EVT Boards ( https://github.com/openwch/arduino_core_ch32 ) is very similar to other Arduino Cores except that it uses a different attachInterrupt() semantic:
https://github.com/openwch/arduino_core_ch32/blob/main/cores/arduino/WInterrupts.h#L27

Author of the CH32 Core has some objections against use of a standard attachInterrupt()
see this ticket for details: openwch/arduino_core_ch32#15

This PR is intended to apply a workaround to the RadioLib (if possible) to allow a build of the library together with Arduino CH32 Core.

I've tested the patch with a sketch for CH32V307 that now builds successfully with RadioLib 7.1.0 and 'master' branch of Arduino Core for CH32.

@jgromes
Copy link
Owner

jgromes commented Nov 7, 2024

I don't think this is a good approach. Arduino has defined API, that includes having signatures for different functions, including attachInterrupt. Dozens of Arduino cores use it, why can't the CH32? I've added a comment to that effect in the issue linked above.

@lyusupov lyusupov closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants