Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LoRa APRS Transmit Example for STM32WLx boards #1335

Closed
wants to merge 6 commits into from

Conversation

radiohound
Copy link
Contributor

Pull request template

Thank you for taking the time to contribute to RadioLib development!
To keep this library organized, please follow these rules.

  1. Make sure the the code in your PR is tested and that you understand all its impacts.
  2. Ensure that all CI actions pass - PRs with failed CI will not be merged. CI actions run automatically for every commit pushed to the PR and test the following:
    a. Compilation for Arduino, ESP-IDF and on Raspberry Pi
    b. Runtime test on Raspberry Pi
    c. GitHub CodeQL check
    d. Cppcheck static code scan
  3. Follow code style guidelines in CONTRIBUTING.md
  4. Heads up - all PRs undergo review, during which you may be asked to correct or change some things. The purpose of this review is to keep regressions and bugs at the minimum, and to keep consistent coding style. Please take them as constructive criticism from people who may have a different point-of-view than you do.

After addressing/accepting the points above, delete the contents of this template and replace it with text explaining what is the goal of your PR, why you want to add it to the upstream and what are the foreseen impacts. Once again, thank you for taking the time to contribute!

@radiohound
Copy link
Contributor Author

Here is an example for transmitting LoRa APRS for the STM32WLx boards. I've tested it for the Nucleo WL55JC2 board and Ebyte's E77 development board.

@jgromes
Copy link
Owner

jgromes commented Nov 28, 2024

I'm not convinced it is necessary to have this as a standalone example. It seems that this mainly adds the RF switching configuration. However, that's not specific to LoRa APRS, that's specific to the STM32WL module.

For this sort of configuration (pinouts of different modules etc.) we have a specific repository: https://github.com/radiolib-org/RadioBoards. For example, this is how RF switching on WM1110 is handled: https://github.com/radiolib-org/RadioBoards/blob/main/src/maintained/SeeedStudio/WM1110.h

If you could contribute the STM32WL configuration over there, that would be great!

@radiohound
Copy link
Contributor Author

Ah, that makes sense. I'll try doing that. Thanks!

@jgromes
Copy link
Owner

jgromes commented Nov 28, 2024

Thanks! In that case I will close this PR.

@jgromes jgromes closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants