Merge pull request #11271 from qmonmert/sonarcircularapps

Sonar: reactivate circular dependency rule on generated apps
jhipster · Nov 1, 2024 · d90ed3d · d90ed3d
2 parents 25fd735 + d1ea2c5
commit d90ed3d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/src/main/resources/generator/server/sonar/sonar-fullstack-project.properties.mustache b/src/main/resources/generator/server/sonar/sonar-fullstack-project.properties.mustache
@@ -25,7 +25,7 @@ sonar.exclusions=\
   src/main/webapp/app/index.tsx,\
   src/main/webapp/main.ts
 
-sonar.issue.ignore.multicriteria=S117,S119,S125_1,S125_2,S3437,S4502,S4684,S4032,S5778,S1133,S6206,S6437,S6564,UndocumentedApi,S2301,S7027
+sonar.issue.ignore.multicriteria=S117,S119,S125_1,S125_2,S3437,S4502,S4684,S4032,S5778,S1133,S6206,S6437,S6564,UndocumentedApi,S2301
 
 # Rule: Local variable and method parameter names should comply with a naming convention
 # Handled with checkstyle. Should be revisited with java 25 once Unnamed Patterns and Variables are available (JEP 443)
@@ -85,7 +85,3 @@ sonar.issue.ignore.multicriteria.S6564.ruleKey=typescript:S6564
 # Rule: Methods should not contain selector parameters
 sonar.issue.ignore.multicriteria.S2301.resourceKey=src/main/webapp/app/auth/oauth2-auth.service.ts
 sonar.issue.ignore.multicriteria.S2301.ruleKey=typescript:S2301
-
-# Rule: Circular dependencies between classes in the same package should be resolved
-sonar.issue.ignore.multicriteria.S7027.resourceKey=src/**/java/**/*
-sonar.issue.ignore.multicriteria.S7027.ruleKey=javaarchitecture:S7027
diff --git a/src/main/resources/generator/server/sonar/sonar-project.properties.mustache b/src/main/resources/generator/server/sonar/sonar-project.properties.mustache
@@ -21,7 +21,7 @@ sonar.exclusions=\
   src/main/webapp/app/index.tsx,\
   src/main/webapp/main.ts
 
-sonar.issue.ignore.multicriteria=S117,S119,S125_1,S125_2,S3437,S4502,S4684,S4032,S5778,S1133,S6206,S6548,S6437,S6471,UndocumentedApi,S2301,S7027
+sonar.issue.ignore.multicriteria=S117,S119,S125_1,S125_2,S3437,S4502,S4684,S4032,S5778,S1133,S6206,S6548,S6437,S6471,UndocumentedApi,S2301
 
 # Rule: Local variable and method parameter names should comply with a naming convention
 # Handled with checkstyle. Should be revisited with java 25 once Unnamed Patterns and Variables are available (JEP 443)
@@ -85,7 +85,3 @@ sonar.issue.ignore.multicriteria.S6471.ruleKey=docker:S6471
 # Rule: Methods should not contain selector parameters
 sonar.issue.ignore.multicriteria.S2301.resourceKey=src/main/webapp/app/auth/oauth2-auth.service.ts
 sonar.issue.ignore.multicriteria.S2301.ruleKey=typescript:S2301
-
-# Rule: Circular dependencies between classes in the same package should be resolved
-sonar.issue.ignore.multicriteria.S7027.resourceKey=src/**/java/**/*
-sonar.issue.ignore.multicriteria.S7027.ruleKey=javaarchitecture:S7027