Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify and simplify vue and react vitest config #10462

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Unify and simplify vue and react vitest config #10462

merged 3 commits into from
Jul 31, 2024

Conversation

murdos
Copy link
Contributor

@murdos murdos commented Jul 31, 2024 •
edited
Loading

  • make vitest configuration inherit from vite configuration
  • use simpler and more canonical include and exclude expressions, relying on default vitest configuration

Preparation for #10421

@murdos murdos requested review from qmonmert and renanfranca July 31, 2024 07:27
renanfranca
renanfranca previously approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@renanfranca renanfranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

qmonmert
qmonmert previously approved these changes Jul 31, 2024
View reviewed changes
@murdos murdos dismissed stale reviews from qmonmert and renanfranca via 01b1539 July 31, 2024 20:47
@murdos murdos force-pushed the unify-vue-react-config branch from b7148be to 01b1539 Compare July 31, 2024 20:47
@murdos murdos force-pushed the unify-vue-react-config branch from 01b1539 to 42898aa Compare July 31, 2024 21:35
@murdos murdos enabled auto-merge July 31, 2024 21:38
@murdos murdos merged commit a28f4e9 into jhipster:main Jul 31, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renanfranca renanfranca renanfranca left review comments

@qmonmert qmonmert qmonmert left review comments

Assignees
No one assigned
Labels
area: refactoring client: react client: vue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@murdos @renanfranca @qmonmert